jcamachor commented on a change in pull request #1852: [CALCITE-3848]
Materialized view rewriting fails for mv consisting of group by on join keys
(Vineet Garg)
URL: https://github.com/apache/calcite/pull/1852#discussion_r390028555
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java
##########
@@ -670,11 +669,12 @@ protected
MaterializedViewAggregateRule(RelOptRuleOperand operand,
}
// We introduce a project on top, as group by columns order is lost
List<RexNode> projects = new ArrayList<>();
- Mapping inverseMapping = rewritingMapping.inverse();
+ Multimap<Integer, Integer> inverseMapping = ArrayListMultimap.create();
Review comment:
Can we make this immutable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
