wenhuitang commented on a change in pull request #1862: [CALCITE-3864] Add
Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and
correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION
URL: https://github.com/apache/calcite/pull/1862#discussion_r397159244
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
##########
@@ -286,8 +286,13 @@ private SqlLibraryOperators() {
opBinding -> {
int precision = opBinding.collectOperandTypes().stream()
.mapToInt(RelDataType::getPrecision).sum();
- return opBinding.getTypeFactory()
- .createSqlType(SqlTypeName.VARCHAR, precision);
+ if (precision > 0) {
Review comment:
Thanks a lot, I have already addressed. And make a little change of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
