DonnyZone commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#issuecomment-603626275 Some comments: (1)In Oracle, `concat` function accepts only two operands. In `SqlLibraryOperators`, We'd better seperate the `CONCAT_FUNCTION` into `CONCAT_FUNCTION` and `ORACLE_CONCAT_FUNCTION`. For `ORACLE_CONCAT_FUNCTION`, we can use `SqlOperandCountRanges.of(2)` to enable the constraint. (2)Implement the `CONCAT_FUNCTION` in SqlFunctions and register the implementation in `RexImpTable`. (3)Update the unparse logic accordingly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
