xndai commented on a change in pull request #1860: [CALCITE-2970] Add
abstractConverter only between derived and required traitset
URL: https://github.com/apache/calcite/pull/1860#discussion_r400561640
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSubset.java
##########
@@ -144,6 +141,22 @@ private void computeBestCost(RelOptPlanner planner) {
}
}
+ public void setDerived() {
+ state |= DERIVED;
+ }
+
+ public void setRequired() {
+ state |= REQUIRED;
+ }
+
+ public boolean isDerived() {
+ return (state & DERIVED) == DERIVED;
+ }
+
+ public boolean isRequired() {
Review comment:
I also feel it's confusing to have REQUIRE/DERIVED status on RelSubset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
