hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add
abstractConverter only between derived and required traitset
URL: https://github.com/apache/calcite/pull/1860#discussion_r400966613
##########
File path: core/src/main/java/org/apache/calcite/plan/Convention.java
##########
@@ -59,8 +61,10 @@
* @param toTraits Target traits
* @return Whether we should add converters
*/
- boolean useAbstractConvertersForConversion(RelTraitSet fromTraits,
- RelTraitSet toTraits);
+ default boolean useAbstractConvertersForConversion(RelTraitSet fromTraits,
+ RelTraitSet toTraits) {
+ return true;
Review comment:
[CALCITE-1148](https://github.com/apache/calcite/pull/210) introduced it,
which is a walk-around for the inefficiency. Now we can turn it on by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
