julianhyde commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r404219456
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -7540,6 +7540,47 @@ public void _testGroupExpressionEquivalenceParams() {
.fails("Column 'C1' not found in any table");
}
+ /**
Review comment:
We need some negative tests, to prove that UNNEST is illegal in non-Presto
conformance.
Consider splitting this method up, and adding comments. It's not clear what
each test case is testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
