asolimando opened a new pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154


   Rebasing https://github.com/apache/calcite-avatica/pulls on master and 
fixing conflicts.
   
   The original PR includes commits for both [CALCITE-4600] and [CALCITE-4602].
   
   While fixing conflicts I found out that merged PRs for [CALCITE-4536] and 
[CALCITE-4757] added tests but did not enable them, so I have added two extra 
commits to enable them (I think it's needed since they are already merged and 
that code is untested at the moment).
   
   PS: whenever a new data type is added to `@Override public ExecuteResult 
prepareAndExecute(`, it must be paired with an addition under `public static 
Collection<AccessorTestHelper> data()`, otherwise it won't be called.
   
   PPS: I suggested to the committer to squash the first two commits starting 
with `[CALCITE-4600]` (I did not do it because it was like this in the original 
PR, it's easier to check what I changed) and leave the rest as separate commits 
for clarity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to