julianhyde commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-928531982
Thanks for doing this. I just ran your top commit and I got a couple of
failures:
```
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest
> testGetArray[30:
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest >
testGetArray[30:
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0]
FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest
> testGetArray[31:
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest >
testGetArray[31:
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4]
FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at
org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.6sec, 1026 completed, 2 failed, 0 skipped,
org.apache.calcite.avatica.AvaticaResultSetConversionsTest
0.5sec, 45 completed, 0 failed, 0 skipped,
org.apache.calcite.avatica.AvaticaClosedStatementTest
```
Let's figure this out, and I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
