snuyanzin commented on a change in pull request #2559:
URL: https://github.com/apache/calcite/pull/2559#discussion_r737273675
##########
File path: site/_docs/reference.md
##########
@@ -2513,6 +2513,9 @@ semantics.
| C | Operator syntax | Description
|:- |:-----------------------------------------------|:-----------
| p | expr :: type | Casts *expr* to *type*
+| b | ARRAY_CONCAT(array [, array ]*) | Concatenates one or
more arrays. If any input argument is `NULL` the function returns `NULL`
Review comment:
Not sure what exactly you are referring to... Probably this
```
tester.checkScalar(
"array_concat(array['hello', 'world'], array['!'], array[cast(null
as char)])",
"[hello, world, !, null]", "CHAR(5) ARRAY NOT NULL");
tester.checkNull("array_concat(cast(null as integer array), array[1])");
```
The key difference here is that in the first test there are elements
`array['hello', 'world', '!']` and `array[null]` while in the second there are
`null` and `array[1]`.
So the tests check that if argument is null then return `null` however if an
argument is a collection containing `null` value it should do normal
concatenation.
In case you are referring to something else please elaborate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
