NobiGo commented on a change in pull request #2559:
URL: https://github.com/apache/calcite/pull/2559#discussion_r737958944



##########
File path: 
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -2657,6 +2664,38 @@ private static RelDataType nullifyType(JavaTypeFactory 
typeFactory,
     }
   }
 
+  /** Implementor for a array concat. */
+  private static class ArrayConcatImplementor extends 
AbstractRexCallImplementor {
+
+    ArrayConcatImplementor() {
+      super(NullPolicy.STRICT, false);
+    }
+
+    @Override String getVariableName() {
+      return "array_concat";
+    }
+
+    @Override Expression implementSafe(RexToLixTranslator translator, RexCall 
call,
+        List<Expression> argValueList) {
+      final BlockBuilder blockBuilder = translator.getBlockBuilder();
+      final Expression list =
+          blockBuilder.append("list", Expressions.new_(ArrayList.class), 
false);

Review comment:
       +1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to