[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

[GitBox]

zabetak commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r999312483


##########
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##########
@@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory 
typeFactory,
     productsTable.addColumn("SUPPLIERID", fixture.intType);
     registerTable(productsTable);
 
+    // Register "EMPTY_PRODUCTS" table.
+    MockTable emptyProductsTable = MockTable.create(this, salesSchema, 
"EMPTY_PRODUCTS",
+        false, 2000D, 0.0);

Review Comment:
   Is it intentional to have rows > masRows?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org