HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1287499498
> > I am using the call context to get the RelMetadataQuery, I think this is not fully formed during the matching of the rule > > @HanumathRao can you elaborate a bit what you mean when you say that the metadata query is not formed during `matches`? Both `matches` and `onMatch` take a `RelOptRuleCall` as parameter and in both cases `call.getMetadataQuery()` is available. Thanks @zabetak, I think I misunderstood your earlier comment. I thought that you are asking me to introduce a predicate in operand supplier itself to rule out the application of the rule. I fixed the code in the latest commit to return false for not applicable cases in matches method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
