tjbanghart commented on code in PR #3034:
URL: https://github.com/apache/calcite/pull/3034#discussion_r1092484458
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -1002,6 +1004,18 @@ protected static void unparseOffset(SqlWriter writer,
@Nullable SqlNode offset)
}
}
+ /**
Review Comment:
In addressing this comment I tried to do both things -- formatting/parse
functions are given a static `FormatModels` instance for parsing strings. This
`FormatModels` receives its element mapping from the `BigQuerySqlDialect`
class.
We could reverse the hierarchy if needed so that the format function holds
the element mapping and the SqlDialect refers to that for unparsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
