tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092488598
########## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.sql.fun.SqlLibrary; +import org.apache.calcite.sql.type.OperandTypes; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.calcite.sql.type.SqlTypeTransforms; +import org.apache.calcite.util.format.FormatElementEnum; +import org.apache.calcite.util.format.FormatModelElement; +import org.apache.calcite.util.format.FormatModelElementAlias; +import org.apache.calcite.util.format.FormatModelElementLiteral; +import org.apache.calcite.util.format.FormatModelUtil; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; + +import java.util.Arrays; +import java.util.List; + +import static org.apache.calcite.util.format.FormatElementEnum.D; +import static org.apache.calcite.util.format.FormatElementEnum.DAY; +import static org.apache.calcite.util.format.FormatElementEnum.DD; +import static org.apache.calcite.util.format.FormatElementEnum.DDD; +import static org.apache.calcite.util.format.FormatElementEnum.DY; +import static org.apache.calcite.util.format.FormatElementEnum.HH24; +import static org.apache.calcite.util.format.FormatElementEnum.IW; +import static org.apache.calcite.util.format.FormatElementEnum.MI; +import static org.apache.calcite.util.format.FormatElementEnum.MM; +import static org.apache.calcite.util.format.FormatElementEnum.MON; +import static org.apache.calcite.util.format.FormatElementEnum.MONTH; +import static org.apache.calcite.util.format.FormatElementEnum.Q; +import static org.apache.calcite.util.format.FormatElementEnum.SS; +import static org.apache.calcite.util.format.FormatElementEnum.TZR; +import static org.apache.calcite.util.format.FormatElementEnum.WW; +import static org.apache.calcite.util.format.FormatElementEnum.YYYY; + +/** A <a href="https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlqr/Format-Models.html";> + * format model</a> is a character literal that describes the format of {@code DATETIME} or {@code + * NUMBER} data stored in a character string. + * + * <p>{@link #unparse(SqlWriter, SqlCall, int, int)} calls + * {@link SqlDialect#getFormatElement(FormatElementEnum)} for known elements and aliases. Consider + * overriding this method if a dialect's format elements differs from those in {@link + * FormatElementEnum} + */ +public class FormatModel extends SqlInternalOperator { Review Comment: I removed this operator class. Instead, I moved most of the classes into the `FormatModels` utility class as you had suggested elsewhere. It makes sense for them to be in a single place and we no longer try to string a string argument as something other than a string (i.e. no more premature optimization to convert a string into a `FormatModel`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
