[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

Wed, 10 May 2023 04:17:25 -0700 


liuyongvs commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3797,6 +3798,16 @@ public static List distinct(List list) {
     return new ArrayList<>(result);
   }
 
+  /** Support the MAP_KEYS function. */
+  public static List mapKeys(Map map) {
+    return (List) map.keySet().stream().collect(Collectors.toList());

Review Comment:
   @zoudan not needs. the runtime will does it like other engine
   
   
![image](https://github.com/apache/calcite/assets/6316753/eab04a04-2f3f-42b2-a871-1a7ffa6afc28)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to