tanclary commented on code in PR #3194:
URL: https://github.com/apache/calcite/pull/3194#discussion_r1190144100


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5361,6 +5361,28 @@ private static void checkIf(SqlOperatorFixture f) {
     f.checkNull("array_length(null)");
   }
 
+  /** Tests {@code MAP_KEYS} function from Spark. */
+  @Test void testMapKeysFunc() {
+    final SqlOperatorFixture f = fixture()
+        .setFor(SqlLibraryOperators.MAP_KEYS)

Review Comment:
   I think it could be good to write a test that fails if library is not set to 
Spark (you only want it to work for Spark).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to