guestli commented on code in PR #3375:
URL: https://github.com/apache/calcite/pull/3375#discussion_r1299165721
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -261,9 +263,24 @@ protected SqlCall as(SqlNode e, String alias, String...
fieldNames) {
/** Returns whether a list of expressions projects all fields, in order,
Review Comment:
According to the code description, I don't think it's enough to determine
Star, so I think it's more appropriate to change the method name to
'projectAllField'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
