guestli commented on code in PR #3375:
URL: https://github.com/apache/calcite/pull/3375#discussion_r1300835774
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7013,6 +7157,38 @@ private void checkLiteral2(String expression, String
expected) {
.withOracle(11).throws_("Lower Oracle version(<12) doesn't support
offset/fetch syntax!");
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5583";>[CALCITE-5583]
+ * Rel2Sql will get an error when select * and join is present</a>. */
+ @Test void testSelectStarWithJoin() {
+ final RelBuilder builder = relBuilder();
Review Comment:
julianhyde, thank you for your review and pointing out these errors. I will
fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
