chucheng92 commented on code in PR #3394:
URL: https://github.com/apache/calcite/pull/3394#discussion_r1303745531
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3694,14 +3693,13 @@ String getVariableName() {
return variableName;
}
- @Nullable NullPolicy getNullPolicy() {
+ public NullPolicy getNullPolicy() {
Review Comment:
why add this `public`? IMHO, It should be a similar qualifier to other
methods in this static class such as `getCondition`, `getVariableName`.
and if we remove @Nullable (we expect to pass specific nonnull enumeration
values), shall we add a `requireNonNull` checking in constructor? otherwise the
below `unboxIfNecessary`method
```
switch (nullPolicy)
```
may cause NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
