julianhyde commented on code in PR #3394:
URL: https://github.com/apache/calcite/pull/3394#discussion_r1304790115
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3694,14 +3693,13 @@ String getVariableName() {
return variableName;
}
- @Nullable NullPolicy getNullPolicy() {
+ public NullPolicy getNullPolicy() {
Review Comment:
Adding the `public` was a mistake. I will revert. (I considered moving
`getNullPolicy` up to the interface, but it didn't work.)
Method parameters are implicitly not-nullable, so a `requireNotNull` is not
necessary. We sometimes use `requireNonNull` in public APIs (so that users get
a nicer exception) but this is not a public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
