LakeShen commented on code in PR #3393:
URL: https://github.com/apache/calcite/pull/3393#discussion_r1340869915
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -4769,19 +4778,51 @@ private void convertValuesImpl(
return;
}
- for (SqlNode rowConstructor1 : values.getOperandList()) {
- SqlCall rowConstructor = (SqlCall) rowConstructor1;
+ SqlCall insertOp = callStack.peek();
+ boolean processDefaults = insertOp != null && containsDefault(values);
Review Comment:
I think this large block of code is the main core logic, but I think there
are some code comments that could help others understand and read the code.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
