julianhyde commented on code in PR #3393:
URL: https://github.com/apache/calcite/pull/3393#discussion_r1341429998
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3801,13 +3806,17 @@ private static boolean all(SqlCall call) {
protected RelNode convertInsert(SqlInsert call) {
RelOptTable targetTable = getTargetTable(call);
+ callStack.push(call);
+
final RelDataType targetRowType =
validator().getValidatedNodeType(call);
assert targetRowType != null;
RelNode sourceRel =
convertQueryRecursive(call.getSource(), true, targetRowType).project();
RelNode massagedRel = convertColumnList(call, sourceRel);
+ callStack.pop();
Review Comment:
Makes sense, but I’d feel more confident if the test also tested a MERGE
statement.
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3801,13 +3806,17 @@ private static boolean all(SqlCall call) {
protected RelNode convertInsert(SqlInsert call) {
RelOptTable targetTable = getTargetTable(call);
+ callStack.push(call);
+
final RelDataType targetRowType =
validator().getValidatedNodeType(call);
assert targetRowType != null;
RelNode sourceRel =
convertQueryRecursive(call.getSource(), true, targetRowType).project();
RelNode massagedRel = convertColumnList(call, sourceRel);
+ callStack.pop();
Review Comment:
Makes sense, but I’d feel more confident if the test also tested a MERGE
statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
