julianhyde commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1828955438
I'd change `writer.print(" OVER")` to `writer.keyword("OVER")` but it looks
like progress, so +1.
Please check that we are not breaking things on non-BigQuery dialects. If
there's not a test for one such dialect, add one. Or merge your test methods
into something that tests several dialects (BQ + others).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
