tanclary commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1830760578
> I'd change `writer.print(" OVER")` to `writer.keyword("OVER")` but it
looks like progress, so +1.
>
> Please check that we are not breaking things on non-BigQuery dialects. If
there's not a test for one such dialect, add one. Or merge your test methods
into something that tests several dialects (BQ + others).
I will adjust the writer syntax, as for testing:
https://issues.apache.org/jira/browse/CALCITE-6036 describes how `WITHIN
GROUP() OVER()` is not supported yet for the standard `PERCENTILE` functions
but no dialect that I can find allows framing anyways so this change should not
break any current behavior. The `OVER` clause can still use `PARTITION BY` in
this context so I will add a test that showcases that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
