tindzk commented on code in PR #3687:
URL: https://github.com/apache/calcite/pull/3687#discussion_r1505911089
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -8301,6 +8302,65 @@ private void checkGetTimestamp(Connection con) throws
SQLException {
});
}
+ @Test void bindByteParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setByte(1, (byte) 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindShortParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setShort(1, (short) 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindIntParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setInt(1, 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindLongParameter() {
Review Comment:
Thanks for clarifying. `CAST(300 as TINYINT)` is correctly fine, but `CAST(?
as TINYINT)` does not trigger an error when the value is out of bounds. I added
a test and fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
