tindzk commented on code in PR #3687:
URL: https://github.com/apache/calcite/pull/3687#discussion_r1507339039
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java:
##########
@@ -622,9 +622,49 @@ public static UnaryExpression convert_(Expression
expression, Type type,
* operation that throws an exception if the target type is
* overflowed.
*/
- public static UnaryExpression convertChecked(Expression expression,
+ public static Expression convertChecked(Expression expression,
Type type) {
- throw Extensions.todo();
+ if (type == Byte.class
Review Comment:
Nice. Your approach seems to cover more scenarios.
I will keep `convertChecked` as-is for now. The inlined validations should
be sufficient within the current PR's scope, but feel free to replace it once
#3589 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
