caicancai commented on PR #3711: URL: https://github.com/apache/calcite/pull/3711#issuecomment-1986684148
> Can you be more specific? What problem? You can find that I defined ReturnTypes.DOUBLE_FORCE_NULLABLE in LOG10_MS. The purpose is to make LOG10_MS return null when log10(0). However, during my debugging process, I found that the ReturnTypes.DOUBLE_FORCE_NULLABLE I defined 2 did not take effect. ```java @LibraryOperator(libraries = {MYSQL, SPARK}) public static final SqlFunction LOG10_MS = ((SqlBasicFunction) LOG10).withKind(SqlKind.LOG10_MS) .withReturnTypeInference(ReturnTypes.DOUBLE_FORCE_NULLABLE); ``` Regarding the ReturnType processing of LOG10, it still follows the ReturnType logic of LOG10 in `SqlStdOperatorTable` ```java public static final SqlFunction LOG10 = SqlBasicFunction.create("LOG10", ReturnTypes.DOUBLE_NULLABLE, OperandTypes.NUMERIC, SqlFunctionCategory.NUMERIC); ``` Can you understand what I mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org