caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1518454856
########## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ########## @@ -638,12 +640,16 @@ Builder populate() { defineMethod(EXP, BuiltInMethod.EXP.method, NullPolicy.STRICT); defineMethod(POWER, BuiltInMethod.POWER.method, NullPolicy.STRICT); defineMethod(ABS, BuiltInMethod.ABS.method, NullPolicy.STRICT); - defineMethod(LOG2, BuiltInMethod.LOG2.method, NullPolicy.STRICT); map.put(LN, new LogImplementor()); map.put(LOG, new LogImplementor()); map.put(LOG10, new LogImplementor()); + map.put(LN, new LogMSImplementor()); Review Comment: ohhh, thank you for reminding me, I made a serious mistake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org