caicancai commented on code in PR #3789:
URL: https://github.com/apache/calcite/pull/3789#discussion_r1590337403
##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -512,8 +512,7 @@ public enum BuiltInMethod {
SAFE_DIVIDE(SqlFunctions.class, "safeDivide", double.class, double.class),
SAFE_MULTIPLY(SqlFunctions.class, "safeMultiply", double.class,
double.class),
SAFE_SUBTRACT(SqlFunctions.class, "safeSubtract", double.class,
double.class),
- LOG(SqlFunctions.class, "log", long.class, long.class),
- LOG2(SqlFunctions.class, "log2", long.class),
+ LOG(SqlFunctions.class, "log", long.class, long.class, int.class),
Review Comment:
Maybe this requires an enum instead of a numeric flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
