normanj-bitquill commented on code in PR #3789:
URL: https://github.com/apache/calcite/pull/3789#discussion_r1613811864
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -645,12 +646,14 @@ Builder populate() {
defineMethod(EXP, BuiltInMethod.EXP.method, NullPolicy.STRICT);
defineMethod(POWER, BuiltInMethod.POWER.method, NullPolicy.STRICT);
defineMethod(ABS, BuiltInMethod.ABS.method, NullPolicy.STRICT);
- defineMethod(LOG2, BuiltInMethod.LOG2.method, NullPolicy.STRICT);
map.put(LN, new LogImplementor());
map.put(LOG, new LogImplementor());
map.put(LOG10, new LogImplementor());
+ map.put(LOG_MYSQLSPARK, new LogMysqlSparkImplementor());
Review Comment:
The issue isn't with the static variable name, it is with the value of name
in the `SqlBasicFunction` object. Both `LOG` and `LOG_MYSQLSPARK` use the same
value for the name (and for kind).
If you debug at this point, you can see if it is replacing or adding a new
entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
