normanj-bitquill commented on code in PR #3828:
URL: https://github.com/apache/calcite/pull/3828#discussion_r1649453561


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java:
##########
@@ -72,6 +72,8 @@ public enum SqlLibrary {
   /** A collection of operators that are in PostgreSQL but not in standard
    * SQL. */
   POSTGRESQL("p", "postgresql"),
+  /** A collection of operators that are in RedShift but not in standard SQL. 
*/
+  REDSHIFT("r", "redshift"),

Review Comment:
   @mihaibudiu I ran into a problem with this:
   
https://github.com/apache/calcite/blob/main/babel/src/test/java/org/apache/calcite/test/BabelQuidemTest.java#L110
   
   Both Oracle and PostgreSQL have `GREATEST` and `LEAST` functions but they 
behave differently. I needed some way for RedShift to be able to choose only 
one implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to