mihaibudiu commented on code in PR #3828:
URL: https://github.com/apache/calcite/pull/3828#discussion_r1663164175
##########
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##########
@@ -1900,6 +1902,60 @@ private static class GreatestConvertlet implements
SqlRexConvertlet {
}
}
+ /** Convertlet that converts {@code GREATEST} and {@code LEAST}. */
+ private static class GreatestPgConvertlet implements SqlRexConvertlet {
+ @Override public RexNode convertCall(SqlRexContext cx, SqlCall call) {
Review Comment:
yes, your intermediate language is as expressive as SQL. That's what I mean.
But if you have let expressions you can do much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
