caicancai commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1669546075
########## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ########## @@ -2237,13 +2237,21 @@ private static RelDataType deriveTypeMapFromEntries(SqlOperatorBinding opBinding OperandTypes.NUMERIC_OPTIONAL_NUMERIC, SqlFunctionCategory.NUMERIC); - /** The "LOG(numeric, numeric1)" function. Returns the base numeric1 logarithm of numeric. */ + /** The "LOG(numeric[,numeric1])" function. Returns the base numeric1 logarithm of numeric. */ @LibraryOperator(libraries = {MYSQL, SPARK}) public static final SqlFunction LOG_MYSQL = SqlBasicFunction.create(SqlKind.LOG, ReturnTypes.DOUBLE_FORCE_NULLABLE, OperandTypes.NUMERIC_OPTIONAL_NUMERIC); + /** The "LOG(numeric[,numeric1])" function. Returns the base numeric1 logarithm of numeric. */ Review Comment: I modified it according to the official MySQL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org