caicancai commented on code in PR #3839:
URL: https://github.com/apache/calcite/pull/3839#discussion_r1678567869
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2785,41 +2785,69 @@ public static double power(BigDecimal b0, BigDecimal
b1) {
return Math.pow(b0.doubleValue(), b1.doubleValue());
}
-
// LN, LOG, LOG10, LOG2
- /** SQL {@code LOG(number, number2)} function applied to double values. */
- public static @Nullable Double log(double number, double number2, int
nullFlag) {
- if (nullFlag == 1 && number <= 0) {
+ /**
+ * SQL {@code LOG(number, base)} function applied to double values.
+ *
+ * @param dialectflag This parameter is used to specify the SQL dialect for
the LOG function.
+ * 0 represents MySQL dialect, 1 represents BigQuery dialect, and 2
represents PostgreSQL dialect.
+ */
+ public static @Nullable Double log(double number, double base, int
dialectflag) {
+ if (dialectflag == 0 && number <= 0) {
Review Comment:
yes, you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
