mihaibudiu commented on code in PR #3892:
URL: https://github.com/apache/calcite/pull/3892#discussion_r1697757042
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3682,9 +3682,22 @@ static AbstractRexCallImplementor
of(AbstractRexCallImplementor implementor) {
@Override Expression implementSafe(final RexToLixTranslator translator,
final RexCall call, final List<Expression> argValueList) {
+ // E.g., "final Boolean resultValue = (callValue == null) ? null :
!callValue"
final Expression expression =
implementor.implementSafe(translator, call, argValueList);
- return Expressions.not(expression);
+ final ParameterExpression callValue =
Review Comment:
The isn't the bug in the contents of the map, and not in the NotImplementor?
There should be a call in between which converts null to false. I imagine this
pattern must show up in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
