mihaibudiu commented on code in PR #3892:
URL: https://github.com/apache/calcite/pull/3892#discussion_r1699247403
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3682,9 +3682,22 @@ static AbstractRexCallImplementor
of(AbstractRexCallImplementor implementor) {
@Override Expression implementSafe(final RexToLixTranslator translator,
final RexCall call, final List<Expression> argValueList) {
+ // E.g., "final Boolean resultValue = (callValue == null) ? null :
!callValue"
final Expression expression =
implementor.implementSafe(translator, call, argValueList);
- return Expressions.not(expression);
+ final ParameterExpression callValue =
Review Comment:
NotImplementor is used in many other places, and you are changing the
semantics of all of these.
Wouldn't it be simpler to just fix the expression computing
IS_NOT_JSON_VALUE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
