mihaibudiu commented on code in PR #3909:
URL: https://github.com/apache/calcite/pull/3909#discussion_r1710103702
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -8367,23 +8367,15 @@ void checkArrayReverseFunc(SqlOperatorFixture f0,
SqlFunction function,
final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
f.checkScalar("map_keys(map['foo', 1, 'bar', 2])", "[foo, bar]",
"CHAR(3) NOT NULL ARRAY NOT NULL");
- f.checkScalar("map_keys(map['foo', 1, null, 2])", "[foo, null]",
- "CHAR(3) ARRAY NOT NULL");
+
Review Comment:
can you see who added these tests in the first place and check why they
added them? maybe the behavior has changed, or maybe they are not testing spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
