julianhyde commented on code in PR #3909:
URL: https://github.com/apache/calcite/pull/3909#discussion_r1710423016
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -5682,11 +5682,21 @@ public static List mapEntries(Map<Object, Object> map) {
/** Support the MAP_KEYS function. */
public static List mapKeys(Map map) {
+ for (Object key : map.keySet()) {
+ if (key == null) {
+ throw new IllegalArgumentException("Cannot use null as map key");
Review Comment:
You should `throw RESOURCE.something`. We have resources for error messages
that the user might see during normal operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
