caicancai commented on code in PR #3909:
URL: https://github.com/apache/calcite/pull/3909#discussion_r1718469508


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -5682,11 +5682,17 @@ public static List mapEntries(Map<Object, Object> map) {
 
   /** Support the MAP_KEYS function. */
   public static List mapKeys(Map map) {
+    if (map.keySet().contains(null)) {

Review Comment:
   I guess what you mean is that you want to check for null values ​​when 
checking parameters. My current implementation is based on spark.
   If you need me to modify the implementation, I can accept it. This is just a 
small change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to