mihaibudiu commented on code in PR #4005:
URL: https://github.com/apache/calcite/pull/4005#discussion_r1801879340
##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowAdapterTest.java:
##########
@@ -278,13 +273,12 @@ static void initializeArrowState(@TempDir Path
sharedTempDir)
if (Bug.CALCITE_6294_FIXED) {
plan = "PLAN=ArrowToEnumerableConverter\n"
+ " ArrowProject(intField=[$0], stringField=[$1])\n"
Review Comment:
how can both sides be changed?
The above bug should ensure that one side is never executed.
##########
core/src/main/java/org/apache/calcite/util/Bug.java:
##########
@@ -204,11 +204,6 @@ public abstract class Bug {
* is fixed. */
public static final boolean CALCITE_6391_FIXED = false;
- /** Whether
- * <a
href="https://issues.apache.org/jira/browse/CALCITE/issues/CALCITE-6293";>
- * [CALCITE-6293] Support OR condition in Arrow adapter</a> is fixed. */
- public static final boolean CALCITE_6293_FIXED = false;
Review Comment:
is this not used anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
