caicancai commented on code in PR #4005:
URL: https://github.com/apache/calcite/pull/4005#discussion_r1803182284
##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowAdapterTest.java:
##########
@@ -278,13 +273,12 @@ static void initializeArrowState(@TempDir Path
sharedTempDir)
if (Bug.CALCITE_6294_FIXED) {
plan = "PLAN=ArrowToEnumerableConverter\n"
+ " ArrowProject(intField=[$0], stringField=[$1])\n"
Review Comment:
@mihaibudiu Sorry, I misunderstood.
Here is my explanation.
`where in (0, 1, 2)` will be translated into
`ArrowFilter(condition=[SEARCH($0, Sarg[0, 1, 2])]) `in the filter, and then
translated into `OR(=($0, 0), =($0, 1), =($0, 2))`.
The same goes for `where "intField"=12 or "intField"= 11`, which will be
translated into `ArrowFilter(condition=[SEARCH($0, Sarg[11, 12])])`, and then
translated into `OR(=($0, 11), =($0, 12))`
Since my changes support `OR(=($0, 0), =($0, 1), =($0, 2) `and similar OR
operators, it seems that they are all effective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
