mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1828552104


##########
core/src/test/java/org/apache/calcite/test/UdfTest.java:
##########
@@ -407,14 +414,33 @@ private CalciteAssert.AssertThat withUdf() {
         .returns("P=null\n");
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-6645";>[CALCITE-6645]
+   * User-defined function with niladic parentheses</a>. */
+  @Test void testUserDefinedFunctionWithNiladicParentheses() {

Review Comment:
   In general you should wait to squash the commits until the PR has been 
approved.
   This makes reviewing changes easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to