mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819914252
##########
testkit/src/main/java/org/apache/calcite/util/Smalls.java:
##########
@@ -683,6 +683,13 @@ public static int eval(int x) throws
IllegalArgumentException, IOException {
}
}
+ /** User-defined function with niladic parentheses. */
+ public static class MyNiladicParenthesesFunction {
+ public String eval() {
Review Comment:
no need to reply on github for every suggestion - if you plan to do it
anyway in your next commit.
Please add a new commit to the PR if you make changes, to make reviewing
easier.
You will have to squash the commits before they get merged, though, but
after the reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
