mihaibudiu commented on code in PR #3558:
URL: https://github.com/apache/calcite/pull/3558#discussion_r1874545988
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -6998,7 +6998,38 @@ private void checkGetTimestamp(Connection con) throws
SQLException {
with.query(
"select * from \"employee\" where \"full_name\" =
_UTF16'\u82f1\u56fd'")
.throws_(
- "Cannot apply = to the two different charsets ISO-8859-1 and
UTF-16LE");
+ "Cannot apply operation '=' to strings with different charsets
'ISO-8859-1' and 'UTF-16LE'");
+ }
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6146";>[CALCITE-6146]
+ * Target charset should be used when comparing two strings through
+ * CONVERT/TRANSLATE function during validation</a>. */
+ @Test void testStringComparisonWithConvertFunc() {
+ if (false) {
Review Comment:
this doesn't look ready yet, so I will wait until you request a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
