ILuffZhe commented on PR #3558: URL: https://github.com/apache/calcite/pull/3558#issuecomment-2526564212
> I have never used these functions myself, but, assuming the semantics implemented is the correct one, this PR looks fine. > > Can some of these results be validated on another DB? Thank you for the review! @mihaibudiu In earlier's PR, we've tested CONVERT(mysql) and TRANSLATE(bigquery) in function.iq , and you can take a look if it's satisfied. BTW, I'll try to squash the commits if no more new comments come. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
