xiedeyantu commented on code in PR #4208:
URL: https://github.com/apache/calcite/pull/4208#discussion_r1966631853
##########
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##########
@@ -362,7 +362,8 @@ protected boolean deepEquals0(@Nullable Object obj) {
@API(since = "1.24", status = API.Status.INTERNAL)
protected int deepHashCode0() {
- return Objects.hash(traitSet, input.deepHashCode(), exps, hints);
+ return Objects.hash(traitSet, input.deepHashCode(),
Review Comment:
> does this match what happens for other operators?
Maybe other operators need to check deepHashCode. But project's deepHashCode
can due to wrong choose. Changing this can find 2 rules bug, but I already
fixed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
