mihaibudiu commented on code in PR #4208:
URL: https://github.com/apache/calcite/pull/4208#discussion_r1966639657
##########
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##########
@@ -362,7 +362,8 @@ protected boolean deepEquals0(@Nullable Object obj) {
@API(since = "1.24", status = API.Status.INTERNAL)
protected int deepHashCode0() {
- return Objects.hash(traitSet, input.deepHashCode(), exps, hints);
+ return Objects.hash(traitSet, input.deepHashCode(),
Review Comment:
There are two reasons to check what is done in other similar places:
- if this is a bug, we should try to find out whether the bug appears in
other places so we can fix it. Not in this PR, but at least we can file a new
issue about it.
- if no other place checks field names, perhaps the intent of the digest is
to ignore field names, and then maybe the bug is elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
