mihaibudiu commented on code in PR #4260:
URL: https://github.com/apache/calcite/pull/4260#discussion_r2010773279
##########
core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java:
##########
@@ -50,30 +52,59 @@ public class JoinInfo {
/** Creates a JoinInfo. */
protected JoinInfo(ImmutableIntList leftKeys, ImmutableIntList rightKeys,
- ImmutableList<RexNode> nonEquiConditions) {
- this.leftKeys = requireNonNull(leftKeys, "leftKeys");
- this.rightKeys = requireNonNull(rightKeys, "rightKeys");
- this.nonEquiConditions =
- requireNonNull(nonEquiConditions, "nonEquiConditions");
+ ImmutableList<RexNode> nonEquiConditions, ImmutableList<Boolean>
filterNulls,
Review Comment:
changing the signature of protected methods is a breaking change, which will
affect projects that use calcite.
I don't understand why JoinInfo needs to be changed if the problem is in the
EnumerableJoinRule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
