asolimando commented on code in PR #4373:
URL: https://github.com/apache/calcite/pull/4373#discussion_r2095321709
##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -399,7 +399,7 @@ private CoreRules() {}
MinusToDistinctRule.Config.DEFAULT.toRule();
/** Rule to translates a {@link Minus} to {@link Join} anti-join}. */
- public static final MinusToAntiJoinRule MINUS_TO_ANTI_JOIN_RULE =
+ public static final MinusToAntiJoinRule MINUS_TO_ANTI_JOIN =
Review Comment:
This was introduced after `1.39.0`, so it's an unreleased feature at the
moment, even assuming someone is using it from a snapshot, I personally
consider breaking changes only w.r.t. released versions, so for me we are still
in time to change this before `1.40.0`, but that's my personal opinion, maybe
someone could confirm or deny my assumption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
