asolimando commented on code in PR #4373:
URL: https://github.com/apache/calcite/pull/4373#discussion_r2096104851
##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -399,7 +399,7 @@ private CoreRules() {}
MinusToDistinctRule.Config.DEFAULT.toRule();
/** Rule to translates a {@link Minus} to {@link Join} anti-join}. */
- public static final MinusToAntiJoinRule MINUS_TO_ANTI_JOIN_RULE =
+ public static final MinusToAntiJoinRule MINUS_TO_ANTI_JOIN =
Review Comment:
You mean specifically for this change or in general? For this change, just
do it through the IDE's refactoring features so there should be no
discrepancies due to the renaming.
At that point you can safely squash as Mihai has already approved the PR
(and this change), if tests are green the contribution will be good to be
merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
